feat: App stats availability measurement #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrmp
force-pushed
the
stats-availability
branch
from
2ae8a06
to
6ca481b
Compare
ctlong
requested changes
Apr 30, 2024
Currently concerned with when stats are seen as unavailable by the client. Does not include when stats are set to zero by the Cloud Controller when one or more required metrics are missing. Co-authored-by: Rebecca Roberts <rebecca.roberts@broadcom.com>
acrmp
force-pushed
the
stats-availability
branch
from
6ca481b
to
e615430
Compare
ctlong
approved these changes
May 1, 2024
ctlong
approved these changes
May 1, 2024
winkingturtle-vmw
added a commit
to winkingturtle-vmw/cf-deployment-concourse-tasks
that referenced
this pull request
May 9, 2024
Context: cloudfoundry/uptimer#115 After adding this new measurement, our CI is failing this measurement because the default value of 0 is too aggresssive for cf-deployment. This PR adds the ablity to set app_stats when needed.
8 tasks
ctlong
pushed a commit
to cloudfoundry/cf-deployment-concourse-tasks
that referenced
this pull request
May 9, 2024
Context: cloudfoundry/uptimer#115 After adding this new measurement, our CI is failing this measurement because the default value of 0 is too aggresssive for cf-deployment. This PR adds the ablity to set app_stats when needed.
jochenehret
added a commit
to cloudfoundry/cf-deployment
that referenced
this pull request
May 13, 2024
* don't run the upgrade jobs two times as the second attempt is a BOSH no-op and will not measure anything meaningful * configure stats check threshold (see cloudfoundry/uptimer#115)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently concerned with when stats are seen as unavailable by the client. Does not include when stats are set to zero by the Cloud Controller when one or more required metrics are missing.