Support running uptimer against an isolation segment #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofffranks
force-pushed
the
isolation-segment-support
branch
from
42c61da
to
f937d31
Compare
ctlong
requested changes
Nov 25, 2023
There was a problem hiding this comment.
@geofffranks can you please update the README with a description of the new configuration option.
geofffranks
force-pushed
the
isolation-segment-support
branch
from
f937d31
to
d193f41
Compare
|
Readme has been updated |
ctlong
reviewed
Jun 5, 2024
| ccg.SetOrgDefaultIsolationSegment(c.org, c.cf.IsolationSegment), | ||
| ) | ||
| } | ||
| ret = append(ret, ccg.CreateSpace(c.org, c.space)) |
There was a problem hiding this comment.
Does the space need to be created after the org has been designated for an isolation segment? Like, if the flow was create org -> create space -> designate org for an isolation segment, would the space still be designated for an isolation segment? Just curious.
ctlong
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
isolation_segmentconfig option, to set the isolation segment used on the org/space for pushing + querying apps.