feat: add IAM auth support (required for stack config templating as of atmos 1.86.2)
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting as of atmos 1.18.2.
aknysh
previously approved these changes
Aug 19, 2024
goruha
requested changes
Aug 19, 2024
korenyoni
added
minor
goruha
approved these changes
Aug 20, 2024
|
These changes were released in v3.4.0. |
korenyoni
changed the title
1.18.2)1.86.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
1.86.2references
Notes
I am not quite sure if(EDIT: it's definitely a requirement to put that step behind a condition — https://github.com/cloudposse/github-action-atmos-affected-stacks/actions/runs/10458450730)Configure Plan AWS Credentialsshould be controlled by a condition. In cloudposse/github-action-atmos-terraform-plan, it is controlled by the outputs of cloudposse/github-action-atmos-get-setting. But we cannot use that action within this composite action, as the former is specific to one stack/component, whereas the latter (this repo) is not.I've added additional outputs toconfig, most of which are not referenced at all. However I did this in order to be consistent withcloudposse/github-action-atmos-terraform-plan.