Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #134 - Does not create http_forward when aws_lb_target_group.default is disabled #149

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Nov 2, 2023

  1. Fixes cloudposse#134 - Skips http_forward when aws_lb_target_group.de…

    …fault is disabled
    
    * disables aws_lb_listener.http_forward when default_target_group is not enabled
    * target_group is required when type is 'redirect'
    
    Fixes this Validation error when default_target_group_enabled == 0 :
    
    ```
    module.alb.aws_lb_listener.http_forward[0]: Creating...
    ╷
    │ Error: creating ELBv2 Listener
    (arn:aws:elasticloadbalancing:...:...:loadbalancer/...):
    ValidationError: A target group ARN must be specified
    │       status code: 400, request id:
    7cf9d727-fc77-4d32-a160-cbd175e16e20
    │
    │   with module.alb.aws_lb_listener.http_forward[0],
    │   on .terraform/modules/alb/main.tf line 150, in resource
    "aws_lb_listener" "http_forward":
    │  150: resource "aws_lb_listener" "http_forward" {
    
    ```
    spazm committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d1a69cb View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    60d26fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8b42cf View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Configuration menu
    Copy the full SHA
    58343f3 View commit details
    Browse the repository at this point in the history