Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update variables.tf to allow a availability_zone_count of 1 #165

Closed
wants to merge 2 commits into from
Closed

Update variables.tf to allow a availability_zone_count of 1 #165

wants to merge 2 commits into from

Conversation

ManuelMueller1st
Copy link

what

  • Update variables.tf to allow a availability_zone_count of 1

why

  • This helps reduce costs for small test clusters.

references

  • closes #158

@ManuelMueller1st
Update variables.tf to allow a availability_zone_count of 1
c4b05c6 
This helps reduce costs for small test clusters.
@ManuelMueller1st ManuelMueller1st requested review from a team as code owners June 2, 2023 14:45
@goruha goruha self-assigned this Jun 5, 2023
@goruha
Copy link
Member

goruha commented Jun 5, 2023

/terratest

@ManuelMueller1st
Copy link
Author

@goruha Hello there! I noticed that you have an issue assigned to you. Is there anything I can do to support you in resolving it? Please let me know if there's anything I can do to help.

@ManuelMueller1st
Copy link
Author

@jamengual @woz5999 Anything I can do to support you with this request?

@jamengual
Copy link

could you please update the pr(pull from.main) and run make precommit/terraform

fix: precommit warnings
49a8afb 
[Fixable] List items should be accessed using square brackets
@ManuelMueller1st
Copy link
Author

could you please update the pr(pull from.main) and run make precommit/terraform

And now? 😄

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge stale This PR has gone stale and removed wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

This pull request is now in conflict. Could you fix it @ManuelMueller1st? 🙏

@ManuelMueller1st
Copy link
Author

This project is obviously no longer maintained

@Gowiem
Copy link
Member

Gowiem commented Mar 8, 2024

@ManuelMueller1st what do you mean by that? If you get this into a working + passing state, ping me and I will review. We are mostly volunteer maintainers, so try to set expectations around that and there are 200+ modules that we get emails about.

@Gowiem Gowiem requested review from Gowiem and removed request for woz5999 March 8, 2024 17:26
@ManuelMueller1st ManuelMueller1st deleted the patch-1 branch April 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees

@goruha goruha

Labels
stale This PR has gone stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ManuelMueller1st @goruha @jamengual @Gowiem @hans-d