Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update terraform cloudposse/cloudwatch-logs/aws to v0.6.7 (main) - abandoned #38

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 17, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/cloudwatch-logs/aws (source) module patch 0.6.6 -> 0.6.7

Release Notes

cloudposse/terraform-aws-cloudwatch-logs

v0.6.7

Compare Source

🚀 Enhancements
Fix mistake in policy @​ramses999 (#​38)
what

Fix mistake in policy

why

The policy is created simply by ARN without the ":" construct, which is necessary to create the correct policy for the role.
Without this ":" construct, the policy is created, but it does not work correctly.
This error was discovered when I tried to create a cloudwatch group in the cloudtrail module.
I got the response "Error: Error updating CloudTrail: InvalidCloudWatchLogsLogGroupArnException: Access denied. Verify in IAM that the role has adequate permissions."
After studying the code, I realized that I need to add the construction ":*" in a couple of lines.
My solution looks like this, I need to replace the lines in file :

This line:
join("", aws_cloudwatch_log_group.default..arn),
replaced by
"${join("", aws_cloudwatch_log_group.default.
.arn)}:*"
You need to do this in both identical lines.

Perhaps you can suggest a better solution, I'm new to terraforming.

references

https://github.com/cloudposse/terraform-aws-cloudwatch-logs/issues/37
https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/master/iam.tf#L55


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners May 17, 2023 17:33
@renovate renovate bot added the auto-update This PR was automatically generated label May 17, 2023
@renovate renovate bot requested review from jamengual and srhopkins May 17, 2023 17:33
@renovate
Copy link
Contributor Author

renovate bot commented May 17, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@Gowiem
Copy link
Member

Gowiem commented May 18, 2023

/test all

@Gowiem Gowiem enabled auto-merge (squash) May 18, 2023 15:53
@Gowiem Gowiem added the patch A minor, backward compatible change label May 18, 2023
@renovate renovate bot changed the title chore(deps): update terraform cloudposse/cloudwatch-logs/aws to v0.6.7 (main) chore(deps): update terraform cloudposse/cloudwatch-logs/aws to v0.6.7 (main) - abandoned Oct 11, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Oct 11, 2023

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@Gowiem
Copy link
Member

Gowiem commented Oct 12, 2023

Closing as their is an upgrade to another patch version that is already open.

@Gowiem Gowiem closed this Oct 12, 2023
auto-merge was automatically disabled October 12, 2023 16:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant