Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Revert Breaking Change in v0.6.0 #79

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Bugfix: Revert Breaking Change in v0.6.0 #79

merged 7 commits into from
Aug 28, 2024

Conversation

milldr
Copy link
Sponsor Member

@milldr milldr commented Aug 28, 2024

what

why

  • If we pass everything then the resources created in the cloudwatch module will have new names!

references

@mergify mergify bot added the triage Needs triage label Aug 28, 2024
@milldr
Copy link
Sponsor Member Author

milldr commented Aug 28, 2024

/terratest

@milldr milldr added bugfix Change that restores intended behavior and removed triage Needs triage labels Aug 28, 2024
@milldr
Copy link
Sponsor Member Author

milldr commented Aug 28, 2024

/terratest

@milldr
Copy link
Sponsor Member Author

milldr commented Aug 28, 2024

/terratest

@milldr
Copy link
Sponsor Member Author

milldr commented Aug 28, 2024

/terratest

@milldr milldr marked this pull request as ready for review August 28, 2024 15:22
@milldr milldr requested review from a team as code owners August 28, 2024 15:22
@milldr
Copy link
Sponsor Member Author

milldr commented Aug 28, 2024

/terratest

@milldr milldr mentioned this pull request Aug 28, 2024
Closed
@milldr milldr merged commit 71c4d31 into main Aug 28, 2024
16 checks passed
@milldr milldr deleted the fix/revert-breaking-change branch August 28, 2024 16:17
@github-actions GitHub Actions
Copy link

These changes were released in v0.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.6.0 breaks aws_cloudwatch_log_group names
2 participants
@milldr @aknysh