Minor: Implementation of the aws_lambda_event_source_mapping resource to easily set a stream or a queue as trigger for lambda.
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/terratest |
milldr
reviewed
Aug 27, 2024
|
/terratest |
|
/terratest |
|
Hi @milldr I think I've fixed the terraform/tofu testing passing a few fake parameters, let me know if that's OK and we're ready for another go :) |
milldr
reviewed
Aug 28, 2024
|
/terratest |
|
Cloudposse Dynamo DB table module added to examples |
milldr
reviewed
Aug 28, 2024
|
/terratest |
|
/terratest |
|
💥 This pull request now has conflicts. Could you fix it @nnsense? 🙏 |
|
Hey @milldr, if you have time, could you review again? I hope I've fixed everything, sorry for the delay.. busy days! Thanks :) |
|
/terratest |
|
Fixed (hopefully), overlloked those dots 🤦🏻♂️ |
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Implementation of the
aws_lambda_event_source_mappingresource, allowing to set a Kinesis stream, DynamoDB stream, or SQS queue as a trigger for lambda. I've purposely kept things simple allowing only a few variables:source_mapping_arnpointing to thearnof the triggering resource (eg, the lambda execution role)source_mapping_batch_sizeallowing to tune the number of events we pass to the function.source_mapping_starting_position, because it's usually required and terraform complains if it's unsetsource_mapping_starting_position_timestamp, if someone wants to useAT_TIMESTAMPin Kinesis.why
It's useful to get lambda triggered by other resources without having to set just one resource in another module.