Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter_policy_scope): changed default to null, added tests #88

Merged

Conversation

vladget
Copy link
Contributor

@vladget vladget commented Oct 10, 2024

what

  • Bug fix for default value of filter_policy_scope
  • Added test to avoid a similar bug in the future

why

the default value(MessageAttributes) of filter_policy_scope cause error in the case when filter_policy is unset :

│ Error: filter_policy is required when filter_policy_scope is set
│ 
│   with module.sns_topic["my-topic"].aws_sns_topic_subscription.this["my-topic"],
│   on .terraform/modules/sns_topic/main.tf line 29, in resource "aws_sns_topic_subscription" "this":
│   29: resource "aws_sns_topic_subscription" "this" {

@vladget vladget requested review from a team as code owners October 10, 2024 10:15
@mergify mergify bot added the triage Needs triage label Oct 10, 2024
@osterman
Copy link
Member

/terratest

goruha
goruha previously approved these changes Oct 10, 2024
@mergify mergify bot removed the triage Needs triage label Oct 10, 2024
@mergify mergify bot added the triage Needs triage label Oct 10, 2024
@goruha
Copy link
Member

goruha commented Oct 10, 2024

/terratest

@goruha goruha merged commit 34ba0b8 into cloudposse:main Oct 10, 2024
27 checks passed
@mergify mergify bot removed the triage Needs triage label Oct 10, 2024
Copy link

These changes were released in v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants