Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config deprecation docs #36

Closed
wants to merge 2 commits into from
Closed

Add config deprecation docs #36

wants to merge 2 commits into from

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 24, 2022

what

  • Add config deprecation docs

why

  • Deprecation in favor of v2 modules

references

@nitrocode nitrocode requested review from a team as code owners June 24, 2022 10:53
@nitrocode nitrocode added the no-release Do not create a new release (wait for additional code changes) label Jun 24, 2022
@roman8422
Copy link
Contributor

Why would you want to deprecate config module?
Using one module instead of 10 is much more convenient.
Migrating config to using v2 modules inside looks like a better option to me. Backward compatible migration is possible now using moved{} block.

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

@nitrocode if you can do the required readme update (see failing test), im ok to merge this

Copy link

mergify bot commented Mar 9, 2024

This pull request now has conflicts. Could you fix it @nitrocode? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Mar 9, 2024
@mergify mergify bot closed this Mar 9, 2024
Copy link

mergify bot commented Mar 9, 2024

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Mar 9, 2024
Copy link

mergify bot commented Mar 9, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot removed conflict This PR has conflicts needs-cloudposse Needs Cloud Posse assistance labels Mar 9, 2024
@hans-d hans-d reopened this Mar 10, 2024
Copy link

mergify bot commented Mar 10, 2024

This pull request now has conflicts. Could you fix it @nitrocode? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Mar 10, 2024
Copy link

mergify bot commented Mar 10, 2024

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot closed this Mar 10, 2024
@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Mar 10, 2024
Copy link

mergify bot commented Mar 10, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot removed conflict This PR has conflicts needs-cloudposse Needs Cloud Posse assistance labels Mar 10, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants