Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notification Policy] Improve module #44

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[Notification Policy] Improve module #44

merged 3 commits into from
Jul 22, 2024

Conversation

diraol
Copy link
Contributor

@diraol diraol commented Nov 30, 2023 •
edited
Loading

@diraol diraol requested review from a team as code owners November 30, 2023 19:24
@diraol diraol requested review from Gowiem and korenyoni November 30, 2023 19:24
@diraol
Copy link
Contributor Author

diraol commented Dec 5, 2023 •
edited
Loading

@goruha sorry for the direct poke, but we are indeed in need of this feature for a project :) 🙏🏽

@diraol diraol force-pushed the dro/notification_policy_delay branch from ea51937 to 72aaca6 Compare December 8, 2023 19:43
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@diraol
Copy link
Contributor Author

diraol commented Mar 2, 2024 •
edited
Loading

Hey folks, if you are still open for new contributions I have some other improvements I have done that can be added here. (it is in my fork only for now, and I'd be happy to send it back here).

@hans-d
Copy link

hans-d commented Mar 2, 2024

@diraol certainly open for new contributions. Currently cleaning up a lot of outdated code, so that visibility on new stuff gets improved.
If you can fix this one (the re`dme check will tell you whats missing), would love to see additional contributions in separate prs (easier to review and process).

@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

Thanks @diraol for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the triage Needs triage label Mar 9, 2024
@diraol diraol changed the title Add more items to notification policy resource [Notification Policy] Imrprove module Jun 14, 2024
@diraol diraol force-pushed the dro/notification_policy_delay branch from 017aeff to 4b16bab Compare June 14, 2024 20:59
@diraol
[notification_policy] Improvements
10b4578 
Major improvements on the notification_policy module (and its
counterpart on config module) with more fields and some refactoring

Reference:
https://registry.terraform.io/providers/opsgenie/opsgenie/latest/docs/resources/notification_policy#delay_action
@diraol diraol force-pushed the dro/notification_policy_delay branch from 4b16bab to 10b4578 Compare June 14, 2024 21:12
@diraol
Copy link
Contributor Author

diraol commented Jun 17, 2024

Hey @hans-d sorry for the long time to make it.
I've split the changes into multiple PRs and updated this one too :)
Let's see how it goes.

@diraol diraol changed the title [Notification Policy] Imrprove module [Notification Policy] Improve module Jun 17, 2024
@Benbentwo
Copy link
Member

/terratest

@mergify mergify bot removed the triage Needs triage label Jul 22, 2024
@Benbentwo
Copy link
Member

/terratest

@Benbentwo
Copy link
Member

/terratest

@Benbentwo Benbentwo merged commit 08a701f into cloudposse:main Jul 22, 2024
38 checks passed
@diraol diraol deleted the dro/notification_policy_delay branch July 25, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diraol @hans-d @Benbentwo