Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate snapshots #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Automate snapshots #35

wants to merge 4 commits into from

Conversation

fllaca
Copy link
Contributor

@fllaca fllaca commented Dec 5, 2019

Creates a snapshot before deleting an index.

Snapshots are also rotated every snapshot_delete_after days

@fllaca
Copy link
Contributor Author

fllaca commented Dec 5, 2019 •
edited
Loading

Closes #34

@fllaca fllaca mentioned this pull request Dec 5, 2019
Open
@giuliocalzolari
Copy link
Contributor

hi @fllaca looks great!
I will test as soon as possible!

@giuliocalzolari
Copy link
Contributor

Hi @fllaca we're testing a new version of the code, as soon as #37 is merged I will adapt the login to your code.

@giuliocalzolari
Copy link
Contributor

hi @fllaca I've finally merged the PR #37 and also upload the tests folder on #41
In this way, people can spin-up a new cluster using terraform to test the new functionality

due to recent PR there is now some little conflicts can you please have a look?

giuliocalzolari
giuliocalzolari suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@giuliocalzolari giuliocalzolari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update with the latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuliocalzolari giuliocalzolari giuliocalzolari requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fllaca @giuliocalzolari