Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EStop button should display robot state #40

Open
2 tasks
IceSentry opened this issue Oct 19, 2019 · 1 comment
Open
2 tasks

EStop button should display robot state #40

IceSentry opened this issue Oct 19, 2019 · 1 comment
Assignees
Labels
good first issue Good for newcomers to be tested Needs to be tested with the robot

Comments

@IceSentry
Copy link
Collaborator

IceSentry commented Oct 19, 2019

  • Changes the text to "rearm" and change button color to yellow when the estop is activated on the robot
  • Show unavailable and grey out the button when not connected and when no data has been published for more than X seconds.

The node is technically implemented on the robot, but it hasn't been tested for a long time. The react code is also probably not up to date either.

@IceSentry IceSentry self-assigned this Oct 19, 2019
@IceSentry IceSentry added the to be tested Needs to be tested with the robot label Nov 17, 2019
@IceSentry IceSentry added good first issue Good for newcomers and removed enhancement labels Jul 18, 2021
@IceSentry
Copy link
Collaborator Author

IceSentry commented Sep 20, 2021

Technically, this node https://github.com/clubcapra/markhor/tree/master/markhor_estop should publish the status of the estop. From the UI perspective the code is already done to change the button text to rearm based on the status on that node. Unfortunately this hasn't been test in a long time. See this for the UI implementation

useRosSubscribe(topic, (message) => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers to be tested Needs to be tested with the robot
Projects
None yet
Development

No branches or pull requests

1 participant