Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection status is not always representative of actual connection #43

Open
lit-af opened this issue Oct 27, 2019 · 3 comments · Fixed by #63
Open

Connection status is not always representative of actual connection #43

lit-af opened this issue Oct 27, 2019 · 3 comments · Fixed by #63
Labels
bug Something isn't working to be tested Needs to be tested with the robot

Comments

@lit-af
Copy link
Collaborator

lit-af commented Oct 27, 2019

When launching the UI. The status bar shows as connected.
image

Connection status should reflect actual connection status.

Present in the release Electron build v2.0.0 but not on the web version.

@lit-af lit-af added the bug Something isn't working label Oct 27, 2019
@IceSentry
Copy link
Collaborator

This happens because the entire app state is saved on close. We shouldn't save everything in localStorage, we should only save things like configurations made by the user.

see src/store/store.ts and src/store/localStorage.ts

@IceSentry IceSentry reopened this Apr 9, 2020
@IceSentry IceSentry added the to be tested Needs to be tested with the robot label Apr 9, 2020
@IceSentry
Copy link
Collaborator

#63 should fix this issue, but we should test with a real ROS connection to a robot

@IceSentry IceSentry changed the title Connection status at launch is not representative actual connection Connection status at launch is not representative of actual connection Jul 18, 2021
@IceSentry
Copy link
Collaborator

I will keep this issue open because there might still some inconsistencies between the real connection status and the one shown in the UI, but right now it always starts as disconnected when opening the app since the connection status is not persisted.

@IceSentry IceSentry changed the title Connection status at launch is not representative of actual connection Connection status is not always representative of actual connection Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be tested Needs to be tested with the robot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants