Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an icon #189

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Add an icon #189

merged 2 commits into from
Mar 2, 2024

Conversation

patates-cipsi418
Copy link
Contributor

Set the icon of the app to be able to recognise witch app is the web UI
image vs image

@McCaroon
Copy link
Member

McCaroon commented Feb 13, 2024

I thought you had to go in the package.json in order to add an icon and have a bit of code that looks like this:

  "win": {
     "icon": "/public/assets/images/icon/192x192.png",
     "target": [
       "msi"
     ]
   },
   "linux": {
     "icon": "/public/assets/images/icon/192x192.png",
     "target": [
       "deb"
     ]
   },

or is this not valid anymore since we're now on electron ?

@patates-cipsi418
Copy link
Contributor Author

patates-cipsi418 commented Feb 13, 2024

@McCaroon , I tested your suggestion in package.json and it seems that it is not valid with Electron. But your comment made me realize that I forgot to add the icons in the build folder.

Copy link
Member

@Leuchak Leuchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it work. Nice add :P

@Leuchak Leuchak merged commit 9149077 into master Mar 2, 2024
4 checks passed
@Leuchak Leuchak deleted the Add-icon branch March 2, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants