Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapper function added #16

Closed
wants to merge 5 commits into from
Closed

wrapper function added #16

wants to merge 5 commits into from

Conversation

bhbam
Copy link

@bhbam bhbam commented Jun 8, 2023

The wrapper function was added to prevent initializing the configuration over and over and segmentation fault error solved

@dnoonan08
Copy link
Collaborator

@bhbam please also make the changes for the other classes in the testing/utils directory.
https://github.com/bhbam/econt_sw/tree/master/econt_sw/testing/utils

All of these have the same issue (uhal loads the device in the initializer) so would potentially be subject to the same bug if they get called multiple times.

@dnoonan08
Copy link
Collaborator

@bhbam can you also please edit the description for the pull request, just to describe the problem it is trying to fix. This will be useful in case we are trying to look back at the history and remember how we solved this

@bhbam bhbam changed the title rapper function added wrapper function added Jun 8, 2023
@dnoonan08
Copy link
Collaborator

@bhbam It looks like you made the pull request, but then pushed two commits that reverted all of your changes, so nothing is getting changed here. Can you please reset to before the last two commits so that we can review the changes

@bhbam
Copy link
Author

bhbam commented Jun 13, 2023

@bhbam can you also please edit the description for the pull request, just to describe the problem it is trying to fix. This will be useful in case we are trying to look back at the history and remember how we solved this

Sorry I want to push the changes to new branch (not master) so I tried to revert the change. Now I am pushed to new branch and created pull request.

@dnoonan08
Copy link
Collaborator

Closing this pull request without merging. It is superceded by #17

@dnoonan08 dnoonan08 closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants