Skip to content

Commit

Permalink
Remove impersonation lifetime.
Browse files Browse the repository at this point in the history
Per dbt-labs#769 , we shouldn't
need to set the lifetime of an impersonated token. In some edge cases,
attempting to set it to the job execution timeout (> 300 seconds) can
result in authentication failures, even though the job will complete
successfully and authentication creds will be correctly refreshed.
  • Loading branch information
cmc333333 committed Aug 14, 2023
1 parent 3510f76 commit 62bfa11
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion dbt/adapters/bigquery/connections.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ def get_impersonated_credentials(cls, profile_credentials):
source_credentials=source_credentials,
target_principal=profile_credentials.impersonate_service_account,
target_scopes=list(profile_credentials.scopes),
lifetime=(profile_credentials.job_execution_timeout_seconds or 300),
)

@classmethod
Expand Down

0 comments on commit 62bfa11

Please sign in to comment.