Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carrier history #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Carrier history #49

wants to merge 4 commits into from

Conversation

JimmyRushing
Copy link
Collaborator

I added a step in the kmc that creates and populates a directory of binary files containing the hop trajectories. I still want to tie this step to the verbosity but I am creating the pull request now so chris can use the functionality if he wants.

They can be read in with something like the following.

hop-trajectory = np.load('itic/kmc/carrier_pathfiles/30.npy',allow_pickle = True)

Jimmy added 2 commits July 5, 2022 15:48
from them. Still need to link this to verbosity perhaps and maybe just
save one trajectory if verbosity is 0 or whatever.
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #49 (a416d55) into master (7df91fa) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   85.22%   85.18%   -0.05%     
==========================================
  Files           9        9              
  Lines         765      776      +11     
==========================================
+ Hits          652      661       +9     
- Misses        113      115       +2     
Impacted Files Coverage Δ
morphct/mobility_kmc.py 90.68% <100.00%> (+0.53%) ⬆️
morphct/execute_qcc.py 84.21% <0.00%> (-1.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants