Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create Farsi translation #201

Merged
merged 1 commit into from
Jun 9, 2024
Merged

feat: Create Farsi translation #201

merged 1 commit into from
Jun 9, 2024

Conversation

ardavank
Copy link
Contributor

Add fa localization

@ardavank
feat: Create Farsi translation
20cf451 
Add `fa` localization
@ardavank
Copy link
Contributor Author

Add "fa" (Farsi) to the list of supported languages

@cmfcmf
Copy link
Owner

cmfcmf commented Jun 9, 2024

Thank you! I've removed your second commit, because lunr-languages does not support Farsi. You should specify ar as the language in the options instead, or contribute to https://www.npmjs.com/package/lunr-languages to support Farsi explicitly.

@cmfcmf cmfcmf merged commit 5b92d44 into cmfcmf:main Jun 9, 2024
42 of 50 checks passed
cmfcmf pushed a commit that referenced this pull request Jun 9, 2024
@ardavank @cmfcmf
feat: Create Farsi translation (#201)
c94de72
@tahabiyikli tahabiyikli mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardavank @cmfcmf