Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand usage of dependency injection #12

Open
lewishazell opened this issue May 23, 2021 · 0 comments
Open

Expand usage of dependency injection #12

lewishazell opened this issue May 23, 2021 · 0 comments
Assignees
@lewishazell
Labels
enhancement

Comments

@lewishazell
Copy link
Member

While implementing the container, the easier services were added which yielded some design improvements.

We should now look at expanding into more difficult areas requiring more complicated refactors.
@lewishazell lewishazell self-assigned this May 23, 2021
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Create SocketListenerFactory.
df93403 
Services can be injected into the factory to pass into SocketListener, instead of referencing IRCd properties.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Pass log directly into SocketListener constructor.
cbb9dcb 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Use private log property in SocketListener instead of IRCd p…
cb236d4 
…roperty.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Add log parameter to SocketConnector constructor.
0a8453b 
Required for base constructor.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Add SocketConnectorFactory.
472768a 
Used to inject services into SocketConnector.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Daemon: Construct SocketConnector instances with SocketConnectorFactory.
ce83c28 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Use log property in SocketConnector instead of Log in IRCd.
e8e6474 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Create SocketListenerFactory.
9d3183a 
Services can be injected into the factory to pass into SocketListener, instead of referencing IRCd properties.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Pass log directly into SocketListener constructor.
cec1c71 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Use private log property in SocketListener instead of IRCd p…
761bfd3 
…roperty.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Add log parameter to SocketConnector constructor.
df0a027 
Required for base constructor.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Add SocketConnectorFactory.
eff0361 
Used to inject services into SocketConnector.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Daemon: Construct SocketConnector instances with SocketConnectorFactory.
c757f9c 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Use log property in SocketConnector instead of Log in IRCd.
769a0c8 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Create SocketListenerFactory.
585c936 
Services can be injected into the factory to pass into SocketListener, instead of referencing IRCd properties.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Pass log directly into SocketListener constructor.
9747851 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Use private log property in SocketListener instead of IRCd p…
ae1f9c5 
…roperty.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Add log parameter to SocketConnector constructor.
d56f0b1 
Required for base constructor.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Add SocketConnectorFactory.
0381653 
Used to inject services into SocketConnector.

task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Daemon: Construct SocketConnector instances with SocketConnectorFactory.
35dca07 
task: #12
lewishazell added a commit that referenced this issue May 23, 2021
@lewishazell
Network: Use log property in SocketConnector instead of Log in IRCd.
9279ed6 
task: #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lewishazell lewishazell

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lewishazell