Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #13

Open
lewishazell opened this issue May 23, 2021 · 0 comments
Open

Improve error handling #13

lewishazell opened this issue May 23, 2021 · 0 comments
Assignees

Comments

@lewishazell
Copy link
Member

Specifically, we shouldn't really be calling Client.Write() in exception constructors:
image

However, I see the need for standard error handling. The writes in the constructors currently perform this task.

I propose a middleware infrastructure, between PacketManager and the controllers, which would allow us to specify error handlers. Uncaught application exceptions will end up here and can be managed in a standard way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant