Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple configuration #9

Open
joshoxe opened this issue May 23, 2021 · 0 comments · May be fixed by #8
Open

Decouple configuration #9

joshoxe opened this issue May 23, 2021 · 0 comments · May be fixed by #8
Assignees
@joshoxe
Labels
enhancement feature help wanted

Comments

@joshoxe
Copy link
Collaborator

joshoxe commented May 23, 2021

This is a issue for the previous work that has taken place on Bitbucket/Jira

The configuration is tightly tied into the IRCd class and is an old XML standard - we can instead use appsettings.json and make use of IConfiguration to potentially inject the configuration in places it is needed, rather than passing around the IRCd object
@joshoxe joshoxe self-assigned this May 23, 2021
@joshoxe joshoxe linked a pull request May 23, 2021 that will close this issue
Feature/ircd 59 decouple configuration #8
Open
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Move SocketOptions to Options/ subfolders
7a61ddd 
task: #9
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Fix logger configuration initialisation
d8ce3af 
* LoggerElements are now initialised using IOptions
* Attributes now must be specified under a JSON section in the config

Task: #9
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Add ServerOptions
1c0c415 
task: #9
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Clean up SocketOptions
b6a55be 
task: #9
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Convert new IConfiguration to IOptions
e6b953e 
* Fixes a lot of the configuration not being deserialized correctly
* Removes a lot of code duplication from validation

Task: #9
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Fix renamind bugs
318208d 
task: #9
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Remove unused code
02cfd34 
task: #9
joshoxe added a commit that referenced this issue May 23, 2021
@joshoxe
Configuration: Add correct assembly for cryptography types
60b974d 
task: #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshoxe joshoxe

Labels
enhancement feature help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/ircd 59 decouple configuration cmpct/cmpctircd
1 participant
@joshoxe