Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shapeN not supported #282

Open
TheQuantiser opened this issue Sep 29, 2022 · 1 comment
Open

shapeN not supported #282

TheQuantiser opened this issue Sep 29, 2022 · 1 comment

Comments

@TheQuantiser
Copy link

ValidateDatacards.py reports that shapeN is not supported:

https://github.com/cms-analysis/CombineHarvester/blob/112x/CombineTools/src/CombineHarvester_Datacards.cc#L453

Not sure if this is a real Harvester issue or just a lack of updating L453.

@adewit
Copy link
Collaborator

adewit commented Sep 29, 2022

Hi, it's not simply a matter of updating L453 as the remainder of that code does things depending on the type of systematic, and shapeN also doesn't appear in the rest of the file (which is indeed probably an omission).

If you want to run ValidateDatacards in the meantime you could make another version of the card with shapeN replaced by shape, since these checks don't invoke any morphing, so the results should be equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants