Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update JRA code from latest offline case to adapt online requirement #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Fengwangdong
Copy link

Hi Alexx,

I have managed to modify the JRA code with the latest offline package for online use. There are several points conflicting:

  1. JetResponseAnalyzer.cc:
    vertex >=4 (offline) while vertex > = 1 (online), due to the HLT pixel vertices requirement.
  2. addAlgorithm.py:
    (1) srcVtx = OfflinePrimaryVertices (offline) while srcVtx = hltPixelVertices (online)
    (2) kt6Calojets and kt6PFjets objects are not compatible for HLT samples, therefore they have to be commented under the condition of "caloHLT" and "pfHLT"
    (3) sentences corresponding to "parton" have to be commented since there is no parton module in HLT samples for JRA ntuple production
  3. class_def.xml:
    The version number for "JRAEvent" has to be incremented from 25 to 26 because of compilation requirement:

There are many other small changes with the optional parameters, such as the example below for "JetAnalyzers/bin/jet_apply_jec_x.cc". They are necessary for online case!

Some additional things:

  1. The unmatched HLT reco-jet in "JetRespsonseAnalyzer.cc" and "MatchRecToGen.cc" and "addAlgorithm.py"
  2. HLT objects in "JetReconstruction_cff.py"
  3. The response histograms with true pileup variable in the "jet_response_analyzer_x.cc" and "jet_response_and_resolution_x.cc"

In my opinion, it is quite difficult to synchronize the online and offline framework, since they seem to be not compatible. I'm not sure if they can be unified partly instead of all.

Thanks,
Feng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant