Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port support #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Port support #40

wants to merge 2 commits into from

Conversation

cmseaton42
Copy link
Owner

Description, Motivation, and Context

Adds support for use of additional tcp ports

How Has This Been Tested?

Still needs to be tested on a processor

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

Fixes #38

@cmseaton42 cmseaton42 added the enhancement New feature or request label Oct 3, 2018
@cmseaton42
Copy link
Owner Author

@jhenson29 Can you check to make sure there are no adverse effects from this change when you get some time?

@jhenson29
Copy link
Collaborator

Yes, I want to check with an actual router and using a different port. I should have time this week.

@cmseaton42
Copy link
Owner Author

@jhenson29 Did you have a chance to check this in production?

@jhenson29
Copy link
Collaborator

@cmseaton42 I haven’t. I’ve been drowning at work the last few weeks and haven’t really had time to work on this project. I have some hardware physically connected. I just need to make some time to configure the router and run the tests.

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for specifying non standard EtherNet/IP port number
2 participants