-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for base EtherNet/IP Commands and Discovering Devices #49
Open
Penlane
wants to merge
11
commits into
cmseaton42:v2.0.0
Choose a base branch
from
Penlane:enipcommand-support
base: v2.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would vote for the entire reply. |
Remove legacy discovery method and add more information to return of discovery. Add attached interface to return value of Discovery method.
Alright, I extended the data that gets returned by the discovery-utility and adapted the format a little. |
Penlane
force-pushed
the
enipcommand-support
branch
from
May 17, 2019 08:22
f965d77
to
fb7dffa
Compare
I am incorporating these changes into the typescript conversion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR aims at utilizing the ENIP-side of the communication to provide nice QoL features like retrieving asset-data via EtherNet/IP or discovering several devices
Description, Motivation, and Context
The EtherNet/IP features of this library are well separated, which means we can also add more support here.
How Has This Been Tested?
The ListIdentity / ListServices commands have been tested several times on a live PLC.
Same with discovery. I'd like some feedback on how much information the discovery reply should contain. Only IP/Port/Slot? Or the whole listIdentity response?
Screenshots (if appropriate):
New Style of return:
Types of changes
Checklist:
[WIP] Some awesome PR title
)