Subquery Unnesting: Exists + In Support #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jurplel
commented
Dec 7, 2024
•
jurplel
commented
- Support uncorrelated/correlated IN (ANY) and EXISTS clauses (This should effectively make subquery unnesting feature complete!)
- TPC-H Q4, Q16, Q20, and Q22 working
- The remaining queries mostly seem to have plans that are too bad (Q18 has some other issue, fix in the pipeline but it still seems like the plan is too slow).
…ould work with OR
jurplel
commented
Dec 9, 2024
Comment on lines
+70
to
+71
| // TODO: Check that field is of bool type | ||
| 0.5 // TODO: placeholder---how can we get the selectivity? |
There was a problem hiding this comment.
This should be addressed
jurplel
commented
Dec 9, 2024
Comment on lines
+111
to
+112
| // TODO: Check that field is of bool type | ||
| 0.5 // TODO: placeholder---how can we get the selectivity? |
jurplel
commented
Dec 9, 2024
| @@ -198,6 +198,8 @@ impl< | |||
| ); | |||
| join_filter_selectivity | |||
| } | |||
| // TODO: Does this make sense? | |||
skyzh
approved these changes
Dec 10, 2024
yliang412
added a commit
that referenced
this pull request
Dec 10, 2024
#259 added new yml test cases instead of renaming the `.disabled` ones, removing them now. Signed-off-by: Yuchen Liang <yuchenl3@andrew.cmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.