Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implment column ref as logical property #66

Merged
merged 5 commits into from
Feb 13, 2024
Merged

feat: implment column ref as logical property #66

merged 5 commits into from
Feb 13, 2024

Conversation

Gun9niR
Copy link
Contributor

@Gun9niR Gun9niR commented Feb 13, 2024 •
edited
Loading

Derive base table column ref for logical nodes, so that we can know which columns the ColumnRef objects in a predicate refers to.

Tested manually on the two demos. Not sure how to unit test it.

skyzh
skyzh approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once test passes; you can have a separate pull request that dumps properties out in planner test.

@Gun9niR Gun9niR merged commit f5e8f10 into main Feb 13, 2024
1 check passed
@Gun9niR Gun9niR deleted the zhidong/base_table_col_ref branch February 13, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@AveryQi115 AveryQi115 Awaiting requested review from AveryQi115

@yliang412 yliang412 Awaiting requested review from yliang412

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gun9niR @skyzh