Xia shall error

cnadler86 · Oct 10, 2024 · 063e2e9 · 063e2e9
1 parent 01e5cf4
commit 063e2e9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/ESP32.yml b/.github/workflows/ESP32.yml
@@ -142,11 +142,13 @@ jobs:
           fi
           if [ -n "${CAMERA_MODEL}" ]; then
             echo "FW_NAME=${CAMERA_MODEL}" >> $GITHUB_ENV
-            make ${MAKE_CMD} CFLAGS_EXTRA="-DMP_CAMERA_MODEL_${CAMERA_MODEL}=1" all
+            FINAL_CMD="make ${MAKE_CMD} CFLAGS_EXTRA=\"-DMP_CAMERA_MODEL_${CAMERA_MODEL}=1\" all"
           else
             echo "FW_NAME=${BUILD_TARGET}" >> $GITHUB_ENV
-            make ${MAKE_CMD} all
+            FINAL_CMD="make ${MAKE_CMD} all"
           fi
+          echo "Running command: $FINAL_CMD"
+          eval $FINAL_CMD
           mv ~/micropython/ports/esp32/build-${BUILD_TARGET}/firmware.bin ~/firmware.bin
           
 

diff --git a/src/camera_pins.h b/src/camera_pins.h
@@ -192,6 +192,7 @@
 #define MICROPY_CAMERA_PIN_PCLK     21
 
 #elif defined(MP_CAMERA_MODEL_XIAO_ESP32S3)
+#error THIS IS A PLACEHOLDER FOR THE XIAO ESP32-S3 CAMERA PINOUT
 #define MICROPY_CAMERA_PIN_PWDN     -1
 #define MICROPY_CAMERA_PIN_RESET    -1
 #define MICROPY_CAMERA_PIN_XCLK     10