Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Submission #238

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Blog Submission #238

merged 3 commits into from
Oct 11, 2023

Conversation

husky-parul
Copy link
Contributor

Contributed blog post for sustainability week.

@rootfs @leonardpahlke

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 811a6f1
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/652682c3069f0d00083f8a05
😎 Deploy Preview https://deploy-preview-238--tag-env-sustainability.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@husky-parul husky-parul force-pushed the kepler-otel branch 2 times, most recently from 3a296c2 to 7a745d0 Compare October 5, 2023 18:07
@husky-parul
Copy link
Contributor Author

The preview does not have the link to this PR blog. Is this expected behavior?

image

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @husky-parul for working on this blog short notice. I added a few minor comments. 🙌

cc @mkorbi @catblade

@leonardpahlke
Copy link
Member

The preview does not have the link to this PR blog. Is this expected behavior?

We need to add the header text to the blog (see comment #238 (comment)). The blog will appear by the date we specify in the header.

Copy link
Contributor

@catblade catblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually simplify some of this writing. It will be really hard to access for a non-English speaker.

@husky-parul
Copy link
Contributor Author

@leonardpahlke @catblade PTAL
If you approve I can squash the commits.

Also @leonardpahlke
In the preview I don't see the image, just the alternate text.

image

Copy link
Contributor

@guidemetothemoon guidemetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@husky-parul thank you for your contribution!
@leonardpahlke @catblade @husky-parul this blog post is due to be published today. @husky-parul are you able to go through the requested changes or can we merge those ourselves and perform final review?

Signed-off-by: Parul Singh <parsingh@redhat.com>
Signed-off-by: Parul Singh <parsingh@redhat.com>
Signed-off-by: Parul Singh <parsingh@redhat.com>
@husky-parul
Copy link
Contributor Author

@guidemetothemoon Please TAL

@guidemetothemoon
Copy link
Contributor

Thank you for adding the changes, @husky-parul!
@leonardpahlke @catblade I have gone through your comments and resolved those according to the recent commits. Are we good to merge and publish this blog post?

@leonardpahlke leonardpahlke merged commit b209f28 into cncf:main Oct 11, 2023
9 checks passed
@leonardpahlke
Copy link
Member

Thanks @husky-parul 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants