Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n zh: init zh page support with homepage, about us and landspace. #296

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

SamYuan1990
Copy link
Contributor

@SamYuan1990 SamYuan1990 commented Dec 2, 2023

Start zh with page content.
I hope by this PR/issue, we have a minimal scope for enable a new language support as zh.
IMO which is:

  • home page
  • about page
  • landspace page

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 4e8abe8
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/656de51c6dbf9d00083e6a8e
😎 Deploy Preview https://deploy-preview-296--tag-env-sustainability.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SamYuan1990 SamYuan1990 marked this pull request as draft December 2, 2023 11:35
@SamYuan1990 SamYuan1990 changed the title i18n zh: start zh with home page [WIP] i18n zh: start zh with home page Dec 3, 2023
@SamYuan1990
Copy link
Contributor Author

SamYuan1990 commented Dec 3, 2023

@leonardpahlke , I am working on the landspace page and try to translate into Chinese, please let me know if there any update on this article....

or should I split into different PRs for merge?

@SamYuan1990 SamYuan1990 marked this pull request as ready for review December 4, 2023 13:22
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 changed the title [WIP] i18n zh: start zh with home page i18n zh: init zh page support with homepage, about us and landspace. Dec 4, 2023
@SamYuan1990
Copy link
Contributor Author

@leonardpahlke could you please help review this PR?

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sooo much @SamYuan1990! LGTM

@leonardpahlke leonardpahlke merged commit da0dd60 into cncf:main Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants