-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Weighting for Events and Adjust EU KubeCon Talks #349
Fix Weighting for Events and Adjust EU KubeCon Talks #349
Conversation
…ed up accidentally by the green scraper Signed-off-by: Claire Fletcher <claire.fletcher@pexip.com>
✅ Deploy Preview for tag-env-sustainability ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Claire FLetcher <claire.fletcher@pexip.com>
697e0db
to
37c96a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one note about the page weights.
@@ -1,6 +1,7 @@ | |||
--- | |||
title: Kubecon CloudNativeCon EU 2023 | |||
description: TAG Environmental Sustainability presence at Cloud Native Computing Foundation’s flagship conference in Amsterdam, The Netherlands from 18-21 April, 2023. | |||
weight: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to use a very high value like 99 so we dont need to change all the weights with every events page we add, and just count down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a sensible option. Do you envision always having all the past events? I think what I mentioned about a past/upcoming would be good in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's most natural to list the events in chronological order as they happen.
Signed-off-by: Claire Fletcher <claire.fletcher@pexip.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Some of the KubeCon EU talks may have been picked up by the green scraper due to the speakers working for energy companies. Having reviewed these specific talks I don't think they will discuss environmental sustainability.
I have also adjusted the weighting of the events so that they are in order and KubeCon 2024 shows first. When there is more time we can potentially see if we can separate into "Past" and "Upcoming" events.