Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial TAG Env website into Japanese #439

Merged
merged 5 commits into from
Jun 16, 2024

Conversation

naonishijima
Copy link
Contributor

This is the initial commitment to the Japanese website.
I have localized _index.md and search.md only.
We can track progress by #436.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 145cce3
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/66691f78e60a13000853717c
😎 Deploy Preview https://deploy-preview-439--tag-env-sustainability.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@kaitoii11 kaitoii11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the Japanese contents and have some small nits.

website/content/ja/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!!

TBH, I think we should start small. Meaning, we should only copy the minimum necessary files for the localized website.

FYI: The example from the zh team would be helpful.

@leonardpahlke
Copy link
Member

Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>
@naonishijima
Copy link
Contributor Author

@kaitoii11 @Okabe-Junya
Thank you for your review. I deal with it.

Copy link
Contributor

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! I have some nits, when all comments resolved, lgtm!

website/content/ja/_index.md Outdated Show resolved Hide resolved
website/content/ja/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>
@naonishijima
Copy link
Contributor Author

Thanks! Updated.

<!-- cSpell:ignore Linktree -->
TAG Environmental Sustainabilityの最も重要なリンクは、Linktreeページから利用できます: [cncfenvtag](https://linktr.ee/cncfenvtag).

- [GitHubレポジトリ](https://github.com/cncf/tag-env-sustainability)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [GitHubレポジトリ](https://github.com/cncf/tag-env-sustainability)
- [GitHubリポジトリ](https://github.com/cncf/tag-env-sustainability)

please use "リポジトリ" instead of "レポジトリ"

FYI: https://docs.github.com/ja/repositories/

@Okabe-Junya
Copy link
Contributor

I have a nit, so please take a look again!! Thanks!

Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com>
@naonishijima
Copy link
Contributor Author

Thanks! I fixed it.

Copy link
Contributor

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! LGTM :)

## Meetings

毎月第1、第3水曜日の16:00 UTC ([convert to your local
time](https://dateful.com/convert/utc?t=16)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the quality check build failed with this link being invalid and when I try to navigate to this link it doesn't seem to be working for me (getting connection timeout). Can you please check this link? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your check!
dateful.com is not working now(Pages translated into other languages also point to the same link).

I think we need to use another site, or the page we are translating to should state the time in that language.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the links working again. Maybe rerun the test?

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, Thanks!

@leonardpahlke leonardpahlke merged commit 07cb973 into cncf:main Jun 16, 2024
5 of 6 checks passed
@naonishijima naonishijima deleted the initial-japanese branch June 29, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants