Sorting the display order of languages #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
✅ Deploy Preview for tag-env-sustainability ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
On the TAG ENV website, there was no specific order for displaying languages, and the notations were inconsistent. As shown in the image, Chinese was written as "中文" (in the local language), while Korean was written as "Korean" in English.
Change List
Local Language (English notation)This is the same method used by CNCF/Glossary. Please note that CNCF/Glossary is one of the most advanced projects regarding localization