Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add requested changes from KubeCon tag project meeting #83

Merged
merged 11 commits into from
Dec 8, 2023
Merged

add requested changes from KubeCon tag project meeting #83

merged 11 commits into from
Dec 8, 2023

Conversation

mkorbi
Copy link
Member

@mkorbi mkorbi commented Apr 23, 2023

  • Add GitHub Repo to page
  • Add Glossary to page
  • Add Glossary link to landscape

@netlify
Copy link

netlify bot commented Apr 23, 2023 •
edited
Loading

✅ Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 83548f2
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/657367ac48f7f900088589d0
😎 Deploy Preview https://deploy-preview-83--tag-env-sustainability.netlify.app/glossary
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mkorbi mkorbi self-assigned this Apr 23, 2023
@mkorbi
Copy link
Member Author

mkorbi commented Apr 23, 2023

Added also a glossary. Not sure about the right-side menu with the letters.
Shall we change it to the terminologies instead of C, E, G etc?

leonardpahlke
leonardpahlke requested changes Apr 23, 2023
View reviewed changes
Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like that we move the glossary to the website.

website/content/glossary/_index.md Outdated Show resolved Hide resolved
documentation/WhitePapers/SustainabilityUseCasesAndLandscape2023.md Outdated Show resolved Hide resolved
catblade
catblade previously requested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@catblade catblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. Some minor requests for wording changes for clarity.

website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
website/content/glossary/_index.md Outdated Show resolved Hide resolved
documentation/WhitePapers/SustainabilityUseCasesAndLandscape2023.md Outdated Show resolved Hide resolved
@mkorbi mkorbi requested a review from catblade July 15, 2023 17:10
leonardpahlke
leonardpahlke approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to rebase it tho

@leonardpahlke
Copy link
Member

@mkorbi we need to rebase it. @catblade you requested changes that Max included with the last commits.

@leonardpahlke leonardpahlke dismissed catblade’s stale review December 7, 2023 11:56

requested changes have been addressed

@leonardpahlke
Copy link
Member

This branch cannot be rebased due to conflicts

@mkorbi could you take a look

catblade
catblade reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@catblade catblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One not. Address then I'll approve!

website/content/en/glossary/_index.md Outdated
Scope 3: indirect emissions, that not directly can be changed: for example delivery chain caused CO2 pollution


#### **Embodied (Carbon) Emissions**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap this with the emissions. Wrong order.

catblade
catblade approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@catblade catblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkorbi mkorbi merged commit 9fecd41 into main Dec 8, 2023
4 of 6 checks passed
@leonardpahlke leonardpahlke deleted the tag-kubecon-meeting branch December 11, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catblade catblade catblade approved these changes

@leonardpahlke leonardpahlke leonardpahlke approved these changes

Assignees

@mkorbi mkorbi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkorbi @leonardpahlke @catblade