Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add section about path based and domain based routing #78

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

nabuskey
Copy link
Contributor

No description provided.

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Copy link
Contributor

@cmoulliard cmoulliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks as this section helps a lot to understand what idpbuilder do under the hood :-)

Some clarifications are still needed nevertheless and maybe they should be done using a separate PR.

To use a proper wording, here is what I propose to do:

Rename the arg/parameter --host to --domain-name to avoid to confuse the users as this argument is mainly used to route the requests to the host machine running the idpbuilder services (e.g argocd.cnoe.localtest.me, argocd.127.0.0.1.nip.io, argocd.example.com, etc) and is inline with the domain name (or subdomain like cnoe.localtest.me) as documented here: https://en.wikipedia.org/wiki/Domain_name

If we do what I suggest, then we can still propose the arg/parameter --user-path-routing as it exists as it allows the users to define the service to be accessed using the /path like cnoe.localtest.me/argocd, my.example.com/argocd, etc

@nabuskey
Copy link
Contributor Author

nabuskey commented Nov 4, 2024

We should do those in another PR. We need to document what we have now for user usability

@nabuskey nabuskey merged commit d9e1292 into main Nov 6, 2024
3 of 4 checks passed
@nabuskey nabuskey deleted the path-routing-doc branch November 6, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants