This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Chat Application Finished #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add plugin support - add giphy plugin
- Separate complex html into smaller directives - Implement attachments in client-side which are generated by plugins on server-side - Separate AutoScroll as an attribute for reutilisation - Separate directives from templates - Separate directives by functionality
… complex - Implement socketPlugin
- Implement mapped processing instead of chain processing for plugins.
- Implement Default, Error and UknownCommands plugins, remove logic in socket.on('send')
- Use reject when error inside a plugin has occurred.
- Generic errors are also catched and feedback is sent to the user
- add restriction for nickname length - error are not presented as attachments anymore but as messages - changeName is sent as a message instead of a separate command
- Add 'trunk' filter
- Combine userChangeName and changeName.
- Unify duplicated logic - Introduce animations
- Delete renameModal , Create input and confirm modals. - Create modal controllers and modal service.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chat app, supports multiple rooms, giphy, scalable to any command, material-ui, socket-io and acceptably commented. There is still opportunity for using email to use gravatar, but this chat app doesn't have it. It has animations for dialogs and efficient data transfer (avoids sending data that is already in the client). Each tab would be a new chat session, since no cookies or localStorage is used and socketIO session is not shared between tabs.