This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Challenge Completes #4
Open
karudedios
wants to merge
34
commits into
cnverg:master
Choose a base branch
from
karudedios:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karudedios
commented
Feb 5, 2016
- Multiple Rooms
- Giphy Integration
- Private Messages
- Built with ES6 and JSPM
- Gravatar integration
- Room adition/deletion
- Updated README with instructions
- Added new dependencies I'll be using - Refactored server.js for readability
- Adding a Inject decorator in order to inject straight to the class - Adding what I currently believe to be my core, it's prone to be renamed to 'chat' instead of 'app'
- Changing wrong materialize with dogfalo/materialize
- To ensure having all modules loaded when the file gets imported
Now I have to fix whatever it is that I did wrong with the CSS that destroyed everything. Probably end up doing it all over again.
- Adding more constants - Removing unused method on decorators - Adding helpers, to have function composition
- Adding and applying new styles - Changing layout... So many times I can't even count them - Renaming app
- Receiver and Emitter for room creation and deletion. - Rooms stored on .dat file for persistence.
- Removing what had to be removed - Cleaning markup - Updating texts
* Do private conversations
- States for login and logout - Service for dealing with User - Adding constants and refactoring app.controller
- Added factories for managing messages. giphy and sockets - Updated server (work pending here)
I wanted to test faster...
If a message from system arises we don't want the messages to keep on stacking to the last user-sent message.
- Removing what's not used - Fixing some markup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.