scrape.js: Search org for user #75
Merged
+46
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
reviewed
Dec 12, 2017
lib/scrape.js
Outdated
| @@ -4,6 +4,7 @@ const fs = require('fs') | |||
| const json2yaml = require('json2yaml') | |||
|
|
|||
| const GH_USER_BASE = 'https://github.com/users' | |||
| const GH_ORG_BASE = 'https://github.com/orgs' // Ignore InvalidLinkBear | |||
There was a problem hiding this comment.
I think just add github.com to the ignore list in .coafile
jayvdb
requested changes
Dec 12, 2017
lib/scrape.js
Outdated
| @@ -155,14 +167,17 @@ async function findOrganization({ | |||
| async function findGitHubUser({ display_name }, org) { | |||
| if (!org) return | |||
|
|
|||
| display_name = display_name.replace(/ /g, '') | |||
| const shortName = display_name.replace(/ /g, '') | |||
There was a problem hiding this comment.
spaces are not valid in github usernames, so this is a very basic "convert to valid username". There was a npm package which checked legality of a name. What we want is a smarter "convert name into most similar valid github probable username". maybe a npm package already exists; if not, ... create one ;-)
There was a problem hiding this comment.
Oh man, alright, I'm running out of package naming ideas ;)
andrewda
force-pushed
the
even-more-users
branch
3 times, most recently
from
f2c3068
to
4ecec91
Compare
This searches the user's organization for their display name. If the user is found, their username will be linked. Closes coala#8
andrewda
force-pushed
the
even-more-users
branch
from
4ecec91
to
f2934af
Compare
blazeu
reviewed
Dec 12, 2017
| @@ -14,6 +14,7 @@ bears = LineLengthBear | |||
|
|
|||
| [all.links] | |||
| bears = InvalidLinkBear | |||
| link_ignore_regex = (github\.com|\{|\$) | |||
There was a problem hiding this comment.
There's link_ignore_list that uses globbing instead
link_ignore_list = https://github.com/**
jayvdb
approved these changes
Dec 12, 2017
|
ack f2934af |
1 similar comment
|
ack f2934af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This searches the user's organization for their display name. If
the user is found, their username will be used.
Closes #8