crosscluster/logical: properly handle incorrect targets in CREATE stmt #137975
+220
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, if the schema or database were missing from a destination target table in CREATE LOGICALLY REPLICATED TABLE, the planHook would panic. This patch also beefs up testing around user specified replication targets. Fixes cockroachdb#137745 Release note: none
msbutler
force-pushed
the
butler-create-ldr-syntax-bug
branch
from
6fd60cc to
7146cec
Compare
msbutler
requested review from
dt and
jeffswenson
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the schema or database were missing from a destination target table in CREATE LOGICALLY REPLICATED TABLE, the planHook would panic.
This patch also beefs up testing around user specified replication targets.
Fixes #137745
Release note: none