Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where adding a prefab with Spine assets to the node tree causes abnormal display in the scene editor. #18109

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Jan 2, 2025

Re: #
https://forum.cocos.org/t/topic/164583

demo: https://forum.cocos.org/t/topic/164583/4

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

…e causes abnormal display in the scene editor.
if (this.defaultSkin && this.defaultSkin !== '') this.setSkin(this.defaultSkin);
if (this.defaultAnimation) this.animation = this.defaultAnimation.toString();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding a prefab asset to the node tree, the animation settings are applied before the skin settings. This causes the animation to not be set correctly, as the animation depends on the skin.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to add a comment in to codes saying it.

@bofeng-song bofeng-song requested a review from minggo January 2, 2025 03:02
Copy link

github-actions bot commented Jan 2, 2025

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo merged commit 567042a into cocos:v3.8.6 Jan 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants