Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Delete jars before caching targets #223

Merged
merged 1 commit into from
Mar 6, 2024
Merged

feature: Delete jars before caching targets #223

merged 1 commit into from
Mar 6, 2024

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Mar 6, 2024 •
edited
Loading

I was suspicious of the cache we have in worker which is 6 GBs and I found this:
immagine

So, I'm now cleaning the jar before storing the cache, so old jars are dropped.

In worker:

Before:
immagine
After:
immagine

@lolgab lolgab marked this pull request as ready for review March 6, 2024 17:19
@lolgab lolgab requested a review from a team March 6, 2024 17:31
@geirolz geirolz self-requested a review March 6, 2024 17:37
geirolz
geirolz approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@geirolz geirolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolgab lolgab merged commit 0fdc8b5 into master Mar 6, 2024
6 checks passed
@lolgab lolgab deleted the improve-sbt-cache branch March 6, 2024 17:40
@MiguelMarcelino
Copy link

MiguelMarcelino commented Mar 6, 2024 •
edited
Loading

YES! Thank you!

@manufacturist manufacturist mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geirolz geirolz geirolz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolgab @MiguelMarcelino @geirolz