Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Parametrize jdk version #225

Merged
merged 17 commits into from
Apr 11, 2024
Merged

breaking: Parametrize jdk version #225

merged 17 commits into from
Apr 11, 2024

Conversation

tfrgoncalves
Copy link
Contributor

@tfrgoncalves tfrgoncalves commented Apr 3, 2024 •
edited by jira bot
Loading

@tfrgoncalves tfrgoncalves requested a review from a team April 3, 2024 09:14
@tfrgoncalves tfrgoncalves self-assigned this Apr 3, 2024
@tfrgoncalves tfrgoncalves requested review from loliveiracodacy and removed request for a team April 3, 2024 09:14
@tfrgoncalves
Copy link
Contributor Author

tfrgoncalves commented Apr 3, 2024 •
edited
Loading

Releasing major considering our machine image will be bumped to a version with openjdk 17 as default.

  • bump slack orb from 4.12.1 to 4.13.2
  • bump machine executor to a more recent version, ubuntu-2004:2023.10.1
  • bump sbt_docker docker version from 20 to 24
  • refactor sbt_cached command to simplify set job
  • parametrize jdk version
  • add openjdk version parameter to sbt and sbt_docker jobs
  • deprecate sbt job install_sbt_version parameter, only used in codacy-analysis-cli
  • increase sbt job no_output_timeout timeout default value to '15m'

@tfrgoncalves tfrgoncalves marked this pull request as ready for review April 11, 2024 15:30
@tfrgoncalves tfrgoncalves merged commit ff7b3c4 into master Apr 11, 2024
6 checks passed
@tfrgoncalves tfrgoncalves deleted the feat/configurable-jdk-version branch April 11, 2024 15:46
@tfrgoncalves tfrgoncalves mentioned this pull request Apr 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loliveiracodacy loliveiracodacy loliveiracodacy approved these changes

Assignees

@tfrgoncalves tfrgoncalves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfrgoncalves @loliveiracodacy