Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat-602: Added leagacy mode button on Blog Page #603

Merged
merged 2 commits into from
Aug 30, 2024
Merged

feat-602: Added leagacy mode button on Blog Page #603

merged 2 commits into from
Aug 30, 2024

Conversation

ItsFlash10
Copy link
Contributor

@ItsFlash10 ItsFlash10 commented Aug 30, 2024 •
edited
Loading

PR Fixes:

  • Added a legacy mode button to toggle between the new and the old UI on the Blog page.
  • Fixed and improved the legacy UI a lil which was required (eg. header)
  • Improved Mobile and Tablet view.
  • Added pretier-tailwind for sorting the tailwind classes better.

Resolves #602

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@devsargam @hkirat

iPad Air 4 - localhost iPad Air 4 - localhost

iPad Air 4 - localhost iPad Air 4 - localhost

iPhone 13 Pro - localhost iPhone 13 Pro - localhost iPhone 13 Pro - localhost

DailyCodeBlogPage.mp4

@ItsFlash10 ItsFlash10 mentioned this pull request Aug 30, 2024
Closed
@keshav-exe
Copy link
Contributor

GREAT STUFF BRO!

@DeepanshuMishraa
Copy link

great work man!. Can you tell me how you made these different devices preview image?

@ItsFlash10
Copy link
Contributor Author

great work man!. Can you tell me how you made these different devices preview image?

It's an extension, not very accurate in terms of testing but it does the job xD
https://www.webmobilefirst.com/en/

@hkirat
Copy link
Collaborator

hkirat commented Aug 30, 2024

@devsargam

@devsargam
Copy link
Collaborator

Checking after few @hkirat

@hkirat hkirat merged commit ebd1d22 into code100x:main Aug 30, 2024
1 check failed
@hkirat
Copy link
Collaborator

hkirat commented Aug 30, 2024

/bounty $50

@Eshan-Sharma
Copy link

Thanks a lot, @devsargam closes issue #600

@Zafeeruddin
Copy link

Is this mege reverted
Cannot see it now
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: add a legacy mode button to daily-code
7 participants
@ItsFlash10 @keshav-exe @DeepanshuMishraa @hkirat @devsargam @Eshan-Sharma @Zafeeruddin