-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Spaces to muzer (Not in Websocket) and resolved conflicts #95
Added Spaces to muzer (Not in Websocket) and resolved conflicts #95
Conversation
#84 I resolved the conflicts and merge database migrations into two file |
Checking this |
Now it should pass all the checks , i updated the pnpm-lock.yaml file. Now lockfile is up to date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Please follow up sir
Also remove the lock file in the ws |
Hey, if we are using API routes from the start, why are we only introducing actions and not continuing everything in API routes? It just makes things scattered all over the place. |
Yeah makes sense. Good catch 👍 |
@Vishawdeep-Singh Can we please stick to api calls. Make it as routes |
sure done sir |
Man i thought it was the better way to do fetches . But you are right . Should've done that |
@SujithThirumalaisamy Is there anything to change ? |
Will check and update this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I will merge this to a new branch and will create an issue to migrate this to WS
What this PR fix or add ?
Ans-: I have added spaces or rooms to stream music so that one user can create many spaces.
Muzer-Add-Spaces.mp4