Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spaces to muzer (Not in Websocket) and resolved conflicts #95

Conversation

Vishawdeep-Singh
Copy link
Contributor

What this PR fix or add ?
Ans-: I have added spaces or rooms to stream music so that one user can create many spaces.

Muzer-Add-Spaces.mp4

@Vishawdeep-Singh
Copy link
Contributor Author

#84 I resolved the conflicts and merge database migrations into two file

@Vishawdeep-Singh Vishawdeep-Singh changed the title Added Spaces to muzer and resolved conflicts #84 Added Spaces to muzer (Not in Websocket) and resolved conflicts Sep 14, 2024
@Vishawdeep-Singh
Copy link
Contributor Author

@SujithThirumalaisamy

@SujithThirumalaisamy
Copy link
Collaborator

Checking this

@Vishawdeep-Singh
Copy link
Contributor Author

Checking this

Now it should pass all the checks , i updated the pnpm-lock.yaml file. Now lockfile is up to date.

Copy link
Collaborator

@SujithThirumalaisamy SujithThirumalaisamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Please follow up sir

next-app/app/creator/[creatorId]/[spaceId]/page.tsx Outdated Show resolved Hide resolved
next-app/app/dashboard/[spaceId]/page.tsx Outdated Show resolved Hide resolved
next-app/components/HomeView.tsx Outdated Show resolved Hide resolved
next-app/components/HomeView.tsx Show resolved Hide resolved
next-app/prisma/schema.prisma Outdated Show resolved Hide resolved
next-app/package.json Outdated Show resolved Hide resolved
next-app/package.json Outdated Show resolved Hide resolved
next-app/tailwind.config.ts Outdated Show resolved Hide resolved
@SujithThirumalaisamy
Copy link
Collaborator

Also remove the lock file in the ws

@thepradipvc
Copy link
Contributor

Hey, if we are using API routes from the start, why are we only introducing actions and not continuing everything in API routes? It just makes things scattered all over the place.

@SujithThirumalaisamy
Copy link
Collaborator

SujithThirumalaisamy commented Sep 14, 2024

Hey, if we are using API routes from the start, why are we only introducing actions and not continuing everything in API routes? It just makes things scattered all over the place.

Yeah makes sense. Good catch 👍

@SujithThirumalaisamy
Copy link
Collaborator

@Vishawdeep-Singh Can we please stick to api calls. Make it as routes

@Vishawdeep-Singh
Copy link
Contributor Author

@Vishawdeep-Singh Can we please stick to api calls. Make it as routes

sure done sir

@Vishawdeep-Singh
Copy link
Contributor Author

Hey, if we are using API routes from the start, why are we only introducing actions and not continuing everything in API routes? It just makes things scattered all over the place.

Man i thought it was the better way to do fetches . But you are right . Should've done that

@Vishawdeep-Singh
Copy link
Contributor Author

@SujithThirumalaisamy Is there anything to change ?

@SujithThirumalaisamy
Copy link
Collaborator

@SujithThirumalaisamy Is there anything to change ?

Will check and update this

Copy link
Collaborator

@SujithThirumalaisamy SujithThirumalaisamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I will merge this to a new branch and will create an issue to migrate this to WS

next-app/app/creator/[creatorId]/[spaceId]/page.tsx Outdated Show resolved Hide resolved
next-app/package.json Outdated Show resolved Hide resolved
@SujithThirumalaisamy SujithThirumalaisamy changed the base branch from main to feat/spaces September 14, 2024 20:48
@SujithThirumalaisamy SujithThirumalaisamy merged commit e45cbfd into code100x:feat/spaces Sep 15, 2024
@Vishawdeep-Singh Vishawdeep-Singh deleted the feature/added-spaces branch September 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants