From 8eff91304bdcaf4984bccc5549a43d41c19afb33 Mon Sep 17 00:00:00 2001
From: Tudor Amariei <tudor.amariei@commitglobal.org>
Date: Wed, 31 Jul 2024 16:29:54 +0300
Subject: [PATCH] Fix publish workflow

---
 .github/workflows/publish.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 6ea286d..b91861a 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -59,11 +59,14 @@ jobs:
           GH_TOKEN: ${{ github.token }}
 
   publish-pypi:
+    needs: [provenance]
+    # Wait for approval before attempting to upload to PyPI. This allows reviewing the
+    # files in the draft release.
     name: Upload release to PyPI
-    runs-on: ubuntu-latest
     environment:
-      name: pypi
+      name: publish
       url: https://pypi.org/project/NGOHub/${{ github.ref_name }}
+    runs-on: ubuntu-latest
     permissions:
       id-token: write
     steps:
@@ -72,7 +75,6 @@ jobs:
         with:
           repository-url: https://test.pypi.org/legacy/
           packages-dir: artifact/
-# TEMP: Use test.pypi.org until we figure out this is stable
 #      - uses: pypa/gh-action-pypi-publish@ec4db0b4ddc65acdf4bff5fa45ac92d78b56bdf0 # v1.9.0
 #        with:
 #          packages-dir: artifact/