Skip to content

Commit

Permalink
Upgrade python and node (#338)
Browse files Browse the repository at this point in the history
  • Loading branch information
danniel authored Dec 17, 2024
1 parent 8d8093b commit 44172e1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions docker/dockerfiles/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG NODE_VERSION=20.18.0
ARG PYTHON_VERSION=3.12.7
ARG NODE_VERSION=22.12.0
ARG PYTHON_VERSION=3.12.8


FROM node:${NODE_VERSION}-bookworm as frontend

Check warning on line 5 in docker/dockerfiles/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker image / Build and push image to registry

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
Expand Down Expand Up @@ -71,7 +71,7 @@ RUN apt-get update && \
nginx gcc xz-utils gettext

# configure process manager
ARG S6_OVERLAY_VERSION=3.2.0.0
ARG S6_OVERLAY_VERSION=3.2.0.2
ENV S6_CMD_WAIT_FOR_SERVICES_MAXTIME 0

Check warning on line 75 in docker/dockerfiles/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker image / Build and push image to registry

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

ADD https://github.com/just-containers/s6-overlay/releases/download/v${S6_OVERLAY_VERSION}/s6-overlay-noarch.tar.xz /tmp
Expand Down
4 changes: 2 additions & 2 deletions docker/dockerfiles/Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG NODE_VERSION=20.18.0
ARG NODE_VERSION=22.12.0

FROM node:${NODE_VERSION}-bookworm-slim

Expand Down Expand Up @@ -26,7 +26,7 @@ RUN apt-get update && \
apt-get clean


ARG S6_OVERLAY_VERSION=3.2.0.0
ARG S6_OVERLAY_VERSION=3.2.0.2
ENV S6_CMD_WAIT_FOR_SERVICES_MAXTIME 0

ADD https://github.com/just-containers/s6-overlay/releases/download/v${S6_OVERLAY_VERSION}/s6-overlay-noarch.tar.xz /tmp
Expand Down

0 comments on commit 44172e1

Please sign in to comment.