Added the ability to show dicrete values in votes stackbar #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmircea16 is attempting to deploy a commit to the Code for Romania Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/code4romania/reusable-components/q8klroj5z |
|
@mmircea16 can you please also increase the package version so we can prepare for a new release? |
RaduCStefanescu
previously approved these changes
Nov 1, 2020
…for the ones left out the votes are the total number of votes for that party)
RaduCStefanescu
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming at helping with this: code4romania/rezultate-vot-client#86
The change shows the actual number of votes instead of percentages for the kind of elections that don't have the results expressed in number of votes (eg. showing at a national level the number of mayors each party has). The underlying assumption is that the API is returning those values inside the votes field