configuration: add logging section & ad log_level to configuration_opts #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As there is new code introduced, please also provide tests to check the funtionallity. |
olaf-mandel
force-pushed
the
feature/config-logging_levels
branch
2 times, most recently
from
3b3e866
to
d2bf861
Compare
|
Refactored for testability and added test. |
olaf-mandel
force-pushed
the
feature/config-logging_levels
branch
from
d2bf861
to
6cbc257
Compare
olaf-mandel
changed the title
cmeissner
requested changes
Oct 6, 2024
Allow to configure both the logging-levels and targets of various
loggers by adding a new section `logging` to the configuration file.
Each entry in that section configures one logger / channel. An example
config is:
```yaml
logging:
- name root
level: INFO
- name: foomodule.barcollector:
level: WARNING
target: /path/to/my/collector/logfile.log
```
Add `CollectorBase.setLoggers(logger_names)` as a means for collectors derived from `CollectorBase` to easily configure logging-levels. The new method uses the `collector_opts.logging_level` value (if set in the configuration) to set the logging-level of any loggers given to it.
olaf-mandel
force-pushed
the
feature/config-logging_levels
branch
from
6cbc257
to
0ea72f6
Compare
cmeissner
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure both the logging-levels and targets of various loggers by adding a new section
loggingto the configuration file. Each entry in that section configures one logger / channel. An example config is:Add
CollectorBase.setLoggers(logger_names)as a means for collectors derived fromCollectorBaseto easily configure logging-levels. The new method uses thecollector_opts.logging_levelvalue (if set in the configuration) to set the logging-level of any loggers given to it.