Update Ruby to 3.2.2 and Rails to 6.1.7.4 #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asideofcode-dev
force-pushed
the
bumping-versions
branch
3 times, most recently
from
87f3f6b
to
d5936c1
Compare
asideofcode-dev
changed the title
matyikriszta
reviewed
Aug 4, 2023
|
@asideofcode-dev re: webpacker, I don't think we are going to use it anytime soon so let's just leave it out. It looks like it's retired as well and not in active development anymore: https://github.com/rails/webpacker. I think it's been ripped out of Rails 7 anyways (and that's where we want to end up with this upgrade). |
asideofcode-dev
force-pushed
the
bumping-versions
branch
2 times, most recently
from
c13371e
to
bfd2d66
Compare
There was a problem hiding this comment.
@asideofcode-dev can we also update the Ruby version in the .ruby-version file?
Driver should be compared against :chrome not :selenium when taking screenshots on exception.
Just a sanity check to make sure the asset pipeline is wired up correctly
asideofcode-dev
force-pushed
the
bumping-versions
branch
from
bfd2d66
to
690aad6
Compare
asideofcode-dev
force-pushed
the
bumping-versions
branch
from
10709ee
to
6ed3588
Compare
matyikriszta
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails app:updatetasks as usual(1) includes adding webpacker, the new mechanism for compiling JS. But I think this repo is pretty much married to Sprockets. Maybe webpacker can be forward looking. Or the project can opt to not use it, in which case I can rip it out.Took out webpacker since it will be removed in Rails 7./publicto./app/assets. Closes Duplication of assets under ./app and under ./public #1890. It turns out that the assets under./publicwere set to go sinceconfig.assets.unknown_asset_fallbackis set to false by default in Rails 6.x