-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ruby to 3.2.2 and Rails to 6.1.7.4 #1892
Update Ruby to 3.2.2 and Rails to 6.1.7.4 #1892
Conversation
87f3f6b
to
d5936c1
Compare
@asideofcode-dev re: webpacker, I don't think we are going to use it anytime soon so let's just leave it out. It looks like it's retired as well and not in active development anymore: https://github.com/rails/webpacker. I think it's been ripped out of Rails 7 anyways (and that's where we want to end up with this upgrade). |
c13371e
to
bfd2d66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asideofcode-dev can we also update the Ruby version in the .ruby-version file?
Driver should be compared against :chrome not :selenium when taking screenshots on exception.
Just a sanity check to make sure the asset pipeline is wired up correctly
bfd2d66
to
690aad6
Compare
10709ee
to
6ed3588
Compare
rails app:update
tasks as usual(1) includes adding webpacker, the new mechanism for compiling JS. But I think this repo is pretty much married to Sprockets. Maybe webpacker can be forward looking. Or the project can opt to not use it, in which case I can rip it out.Took out webpacker since it will be removed in Rails 7./public
to./app/assets
. Closes Duplication of assets under ./app and under ./public #1890. It turns out that the assets under./public
were set to go sinceconfig.assets.unknown_asset_fallback
is set to false by default in Rails 6.x